48 results found

1. Allow Copy/Paste contents of 'List of Code Analysis Issues' window.

   Sometimes I would like to just copy/paste the issues discovered and include in an email. Currently, I cannot copy the Issues list. It takes too much time/effort to export to a file and then attach that file to an email. Copy/paste would be so much easier.

   2 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

2. Include auto fix for single quote string literals as aliases warning, Issue code: DEP01.

   Create auto fix for Issue code: DEP01 non-standard column aliases because of single quote delimiter. Also need to update SQL Format tool, it is currently using single quote and there is no way I could find to switch it to double quote.

   2 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

3. Make the Issues List more useful - Rule Disable, Specific Help, Hide Issue in List

   The list is useful to drive code positioning, but that's all it does. Rules like ST011 that go against authoritative SQLPass presentations are noise. Yes, we can click the SQP Menu, nav to manage, scroll down, and finally disable, save, then refresh... (out of breath!). Just right-click and Disable rule, which also refreshes the list. That kind of useful RC-Menu. And instead of having to go to the Rule Maint to see exactly what the rule is enforcing, RC-menu has "Show Issue Help" in a bubble, built in. And for those cases where a rule isn't to be shut down, but its repeated presence is acknowledged but not wanted any more, simply RC-menu "Hide Current Rule", with its friend, "Reveal selected Hidden Rules" to give a multi-check list with Apply, so those rule failures are made visible in the list. E.g., I have a short, OLD, proc, not formatted, and it has 14 of the 23 Issues as "Schema name for...is not specified". Noted, thanks, now shut up! Let me see the wood for the trees... Thanks.

   The list is useful to drive code positioning, but that's all it does. Rules like ST011 that go against authoritative SQLPass presentations are noise. Yes, we can click the SQP Menu, nav to manage, scroll down, and finally disable, save, then refresh... (out of breath!). Just right-click and Disable rule, which also refreshes the list. That kind of useful RC-Menu. And instead of having to go to the Rule Maint to see exactly what the rule is enforcing, RC-menu has "Show Issue Help" in a bubble, built in. And for those cases where a rule isn't to be shut down,… more

   4 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

4. compare datatypes in stored procedure calls with defined variables

   When I call a stored procedure, I want SQL Prompt's code analysis rules to be able to tell me if the variables I am passing to the stored procedure are OK.

   For example, if I pass a bigint variable to a SP that has a tinyint input parameter, I want SQL prompt to flag that as a potential issue.

   Similarly, if I am passing a string variable defined locally as nvarchar(150) to a SP that takes only nvarchar(100), it should be flagged as an issue (because I am passing a string that may not "fit" into the input parameter).

   3 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

5. Is there a way to run your code analysis rules against an existing database?

   To help our developers we - as dba's - perform validation against their procedures and database code. The library of rules that is incorporated in SQLPrompt could be a good rule of thumb for the basic stuff of reviewing, so that we can focus on other stuff when validating.
   Is it possible to run the rules "engine" of SQLPrompt against an existing database without having to open the code manually?

   3 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   1 comment  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

6. Implement all of the Find Unused Variables and Parameters functionality in Code Analysis

   Currently Code Analysis does not implement all of the items that Find Unused Variables and Parameters does.

   Specifically I know it's missing:
   - Declared variables that are used before a value is assigned
   - Assigned values that are never used

   Ex.
   With this code:

   DECLARE @Test NVARCHAR(1)
   DECLARE @Test2 INT
   DECLARE @Test3 DATE

   SET @Test = 1

   SET @Test = N'Test' + @Test2

   Code Analysis will flag the DECLARE for @Test for having a NVARCHAR of size 1 and @Test3 for not being used, but it will not flag @Test2 for being used before a value is assigned to it and for the values assigned to @Test1 never being used.

   It would be nice if those additional checks were in Code Analysis so that we could see the real time feedback we get with the other checks. As it stands, we can get to it, but devs have to remember to run that extra check once they are done.

   Currently Code Analysis does not implement all of the items that Find Unused Variables and Parameters does.

   Specifically I know it's missing:
   - Declared variables that are used before a value is assigned
   - Assigned values that are never used

   Ex.
   With this code:

   DECLARE @Test NVARCHAR(1)
   DECLARE @Test2 INT
   DECLARE @Test3 DATE

   SET @Test = 1

   SET @Test = N'Test' + @Test2

   Code Analysis will flag the DECLARE for @Test for having a NVARCHAR of size 1 and @Test3 for not being used, but it will not flag @Test2 for being used before a value is assigned to it… more

   6 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   1 comment  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

7. Add a warning for statements that are not terminated with a semicolon
   2 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

8. Menu option: 'Normalize Line Endings'

   Sometimes line-endings get messed up by source-control (looking at you Git) and "intellisense" will give you lots of green squigglies that you'd rather not commit to the branch.

   A good menu option for SQL Prompt would be 'Normalize Line Endings' with a sub-menu selection of 'Windows' or 'Unix'. Then fire off a regex expression powered search and replace on the file. It's fairly easy to do manually with a Ctrl+Shift+F in Visual Studio, but in SSMS, it's more complicated to do so manually, I think.

   Git does this to me once in a while, and I have to open the SQL file in Visual Studio and run through it. Otherwise, a Ctrl+k, Ctrl+Y will reformat the script, but then I lose all customizations that I worked hard to format. That can be a loss of close to one hour on a 1500 line script.

   Sometimes line-endings get messed up by source-control (looking at you Git) and "intellisense" will give you lots of green squigglies that you'd rather not commit to the branch.

   A good menu option for SQL Prompt would be 'Normalize Line Endings' with a sub-menu selection of 'Windows' or 'Unix'. Then fire off a regex expression powered search and replace on the file. It's fairly easy to do manually with a Ctrl+Shift+F in Visual Studio, but in SSMS, it's more complicated to do so manually, I think.

   Git does this to me once in a while, and I have to open the… more

   9 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

9. "drop user"

   Highlight of today was when I ran

   DROP USER MyUser
   

   In the wrong (production) database.

   Please add a warning to SQL Prompt, like your
   "You're about to execute a DELETE statement without a WHERE clause"

   When you run a DROP USER or a DROP LOGIN statement on a production server. Not only does the user or login disappear, but also all rights granted to the user.

   Maybe add the question “are you in the correct database?”

   3 votes

   Vote Vote Vote

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

   Vote

   We’ll send you updates on this idea

   1 comment  ·  Code Analysis  ·  Delete…  ·  Admin →
   How important is this to you?

   Not at all You must login first! Important You must login first! Critical You must login first!

   We're glad you're here

   Please sign in to leave feedback

   Signed in as (Sign out)

   Close

   Close

10. Autofix for existing functionality

    There are cases where the code analysis detects errors and where the tool already have functionality to correct the issue. For instance with unqualified column names

    2 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

11. Mark same columns in JOIN conditions

    It helps avoiding join on the same column (especially at inner join).
    Example:
    UPDATE A SET Column1 = B.Column2 FROM TableA AS A INNER JOIN Table B ON A.Column3 = A.Column3.
    It happens usually by accident. The statement should be:
    UPDATE A SET Column1 = B.Column2 FROM TableA AS A INNER JOIN Table B ON A.Column3 = B.Column3.

    14 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

12. DEP026, updated to work with spatial code

    w.sysLocationXY.STX, should not generate an code analysis error.

    2 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

13. Implement all SQL Code Guard Rules in SQL Prompt Code Analysis

    There are several rules that are only available in SQL Code Guard. And with SQL Code Guard no longer being maintained they should be implemented in SQL Prompt Code Analysis so that we can avoid having to use two products.

    By our count here are the rules currently not implemented in Code Analysis:

    DEP004 COMPUTE and COMPUTE BY clauses are deprecated
    DEP005 FASTFIRSTROW table hint is deprecated
    DEP008 PASSWORD/MEDIAPASSWORD options in BACKUP/RESTORE statement are deprecated
    DEP010 DBCC CONCURRENCYVIOLATION is deprecated
    DEP017 NON-ANSI join (= or =) is used
    EI001 Incompatible variable type for procedure call
    EI002 Incompatible literal type for procedure call
    EI004 Extra parameter passed
    EI006 Required parameter is not passed
    EI007 Call parameter declared as output
    EI008 Call parameter is not declared as output
    EI009 Call has more parameters than required
    EI010 OPEN of undefined cursor
    EI014 Fetch from cursor with asterisk in select list, unable to check columns
    EI017 Hardcoded current database name in procedure call
    EI019 BEGIN TRANSACTION without ROLLBACK TRANSACTION
    EI020 ROLLBACK TRANSACTION without BEGIN TRANSACTION
    EI022 Fetch from unopened cursor
    EI025 Executing stored procedure without getting result
    EI026 Reference to function in other database
    EI027 Reference to table or view in other database
    CGTIME Timed out
    CGUNP Unparsed SQL
    MI004 Usage of sp_executesql (only in procedure/trigger)
    PE009 No SET NOCOUNT ON before DML
    SC001 Script should end with GO
    SC002 Script should end with empty line
    ST005 IF or ELSE without BEGIN…END block
    ST009 Avoid using GOTO to improve readability
    ST012 Consider using temporary table instead of table variable
    ST014 Procedure name - pattern is not found in allowed patterns
    ST015 Procedure name - pattern is found in disallowed patterns

    There are several rules that are only available in SQL Code Guard. And with SQL Code Guard no longer being maintained they should be implemented in SQL Prompt Code Analysis so that we can avoid having to use two products.

    By our count here are the rules currently not implemented in Code Analysis:

    DEP004 COMPUTE and COMPUTE BY clauses are deprecated
    DEP005 FASTFIRSTROW table hint is deprecated
    DEP008 PASSWORD/MEDIAPASSWORD options in BACKUP/RESTORE statement are deprecated
    DEP010 DBCC CONCURRENCYVIOLATION is deprecated
    DEP017 NON-ANSI join (= or =) is used
    EI001 Incompatible variable type for procedure call
    EI002 Incompatible literal… more

    5 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

14. Ability to run Code Analysis against whole DB

    With the deprecation of SQL Code Guard and it's replacement by Code Analysis there is one feature that we heavily used that is now no longer there, and that is the ability to run SQL Code Guard against the whole DB not just the query on the screen.

    This allowed us to investigate new DBs that we'd inherited to see what sort of cleanup we might be looking at as well as giving us the ability to see if anything had snuck in to our existing DBs without going file by file.

    I know there are other tools (like SQL Enlight) out there that are capable of doing this sort of thing, but I'd prefer to stick with RedGate.

    With the deprecation of SQL Code Guard and it's replacement by Code Analysis there is one feature that we heavily used that is now no longer there, and that is the ability to run SQL Code Guard against the whole DB not just the query on the screen.

    This allowed us to investigate new DBs that we'd inherited to see what sort of cleanup we might be looking at as well as giving us the ability to see if anything had snuck in to our existing DBs without going file by file.

    I know there are other tools (like SQL… more

    16 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    3 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

15. PE019

    I'd like to vote for adding PE019 (Consider using EXISTS instead of IN) to the issues which can be auto-fixed.

    It feels like the kind of re-write that would probably be simpler for a computer to do than a person.

    5 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    1 comment  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

16. SQL Prompt Code Visualization (Like Flow Chart)

    SQL Prompt should be able to Visualize the Code and represent the code like Flow Chart.
    This Feature will be very useful while working with heavy Stored Procedures.

    The Sample Code Visualization image is shared below:

    https://drive.google.com/file/d/1dE0H7UP1MOuOZ4A3e4urUkDlR0FD4474/view?usp=sharing

    21 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    2 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

17. Issue code SC003 when USE is first line

    Issue code SC003 shouldn't happen if the USE statement is at the top of a SQL script.

    3 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

18. Make SQL Prompt & SCG Command line ignore code where scgignore is set

    We have adopted SCG and have commented out areas of code we do not want checking with scgignore. The new version of SCG command prompt and SQL Prompt do not recognise these comments, and report the area of code with warnings.
    Please amend so they are not reported, or at least reported differently so we can ignore.

    13 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    0 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

19. sonarqube

    Have SonarQube plugin that will do code analysis using your rules rather than TSQL or PLSQL plugins

    4 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    1 comment  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

20. Allow custom rules for code analysis

    SQL Prompt has the ability to catch and warn about Update statements without Where clauses.

    How about something similar that catches and warns about security commands like Grant or Deny.

    8 votes

    Vote Vote Vote

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close

    Vote

    We’ll send you updates on this idea

    2 comments  ·  Code Analysis  ·  Delete…  ·  Admin →
    How important is this to you?

    Not at all You must login first! Important You must login first! Critical You must login first!

    We're glad you're here

    Please sign in to leave feedback

    Signed in as (Sign out)

    Close

    Close